diff options
author | dzwdz | 2022-07-09 15:24:58 +0200 |
---|---|---|
committer | dzwdz | 2022-07-09 15:24:58 +0200 |
commit | dad8b261ac7898f4d8cf537ad288ad6a1a74d124 (patch) | |
tree | 610712b313032529195c3e5319ab45b1a7482c65 /src/kernel/pipe.h | |
parent | 2e8e2dc1fb1aaefbe82cc4261c615428aa6250d5 (diff) |
syscalls/pipe: turn into a POSIX-style api with separate rw ends
Without separate read/write ends you can't tell when there are no more writers left if you have multiple readers. Consider this piece of code:
int fd = pipe();
fork(); // execution continues in 2 processes
while (read(fd, &some_buf, sizeof somebuf) >= 0) {
...
}
Once both processes call `read()`, it's obvious that no writes are possible - all the processes that hold a reference to the pipe are currently stuck on a `read()` call, so the kernel could just make it return an error in both. But, what then? It's still possible to write to the pipe, and you can't know if the other process will do that. Thus, if you don't want to miss any output, you have to keep reading the pipe. Forever. Both processes end up stuck.
Having separate read/write ends prevents that.
Diffstat (limited to 'src/kernel/pipe.h')
-rw-r--r-- | src/kernel/pipe.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/kernel/pipe.h b/src/kernel/pipe.h index facaaaa..9040ab1 100644 --- a/src/kernel/pipe.h +++ b/src/kernel/pipe.h @@ -1,7 +1,11 @@ #pragma once #include <kernel/proc.h> +#include <stdbool.h> -void pipe_joinqueue(struct handle *h, bool wants_write, +/* returns false on failure */ +bool pipe_joinqueue(struct handle *h, bool wants_write, struct process *proc, void __user *pbuf, size_t pbuflen); void pipe_trytransfer(struct handle *h); + +void pipe_invalidate_end(struct handle *h); |