From d8a32a1005c33f6b95bbb3699a8f41ff5e19800e Mon Sep 17 00:00:00 2001
From: dzwdz
Date: Mon, 9 Aug 2021 12:47:46 +0200
Subject: a sloppy implementation of path_simplify()

it's kinda bad. it passes the tests, though...
---
 src/kernel/tests/vfs.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

(limited to 'src/kernel/tests')

diff --git a/src/kernel/tests/vfs.c b/src/kernel/tests/vfs.c
index 017f36d..b982098 100644
--- a/src/kernel/tests/vfs.c
+++ b/src/kernel/tests/vfs.c
@@ -8,8 +8,11 @@ TEST(path_simplify) {
 		if (result == 0) { \
 			TEST_COND(len < 0); \
 		} else { \
-			TEST_COND(len > 0); \
-			/* TODO check equality */ \
+			if (len == sizeof(result) - 1) { \
+				TEST_COND(0 == memcmp(result, buf, len)); \
+			} else { \
+				TEST_COND(false); \
+			} \
 		} \
 	} while (0)
 
@@ -17,6 +20,8 @@ TEST(path_simplify) {
 
 	// some easy cases first
 	TEST_WRAPPER("/",         "/");
+	TEST_WRAPPER("/.",        "/");
+	TEST_WRAPPER("//",        "/");
 	TEST_WRAPPER("/asdf",     "/asdf");
 	TEST_WRAPPER("/asdf/",    "/asdf/");
 	TEST_WRAPPER("/asdf//",   "/asdf/");
@@ -31,10 +36,15 @@ TEST(path_simplify) {
 	TEST_WRAPPER("/asdf//.",  "/asdf/");
 
 	// going under the root or close to it
+	TEST_WRAPPER("/..",        0);
 	TEST_WRAPPER("/../asdf",   0);
 	TEST_WRAPPER("/../asdf/",  0);
 	TEST_WRAPPER("/./a/../..", 0);
 	TEST_WRAPPER("/a/a/../..", "/");
+	TEST_WRAPPER("/a/../a/..", "/");
+	TEST_WRAPPER("/a/../../a", 0);
+	TEST_WRAPPER("/../a/../a", 0);
+	TEST_WRAPPER("/../../a/a", 0);
 	TEST_WRAPPER("/////../..", 0);
 	TEST_WRAPPER("//a//../..", 0);
 
-- 
cgit v1.2.3